Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 Replace rose::separator comp with hds::separator #2613

Merged
merged 4 commits into from
Dec 6, 2024
Merged

refactor: 💡 Replace rose::separator comp with hds::separator #2613

merged 4 commits into from
Dec 6, 2024

Conversation

laurenolivia
Copy link
Collaborator

@laurenolivia laurenolivia commented Dec 5, 2024 •
edited
Loading

✅ Closes: ICU-15646

Description

This PR replaces the rose::separator with the hds::separator, removes any styling associated with rose::separator, and removes an integration test that is no longer needed.

Screenshots (if appropriate)

Before 👇
Screenshot 2024-12-05 at 2 37 20 PM

After 👇
Screenshot 2024-12-05 at 2 39 12 PM

How to Test

  1. Visit the login page to view the component change

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@laurenolivia
refactor: 💡 Replace rose::separator comp with hds::separator
75dad07 
This PR replaces the rose::separator with the hds::separator and removes
an integration test that is no longer needed

✅ Closes: ICU-15646
@laurenolivia laurenolivia requested a review from a team as a code owner December 5, 2024 19:57
@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 6:40am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 6:40am

lisbet-alvarez
lisbet-alvarez reviewed Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job cleaning this up & refactoring!
Another file that needs to be deleted is this one: https://github.com/hashicorp/boundary-ui/blob/main/addons/rose/app/components/rose/separator.js

cameronperera
cameronperera approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurenolivia laurenolivia merged commit 85a2684 into main Dec 6, 2024
12 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/replace-rose-separator branch December 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronperera cameronperera cameronperera approved these changes

@lisbet-alvarez lisbet-alvarez Awaiting requested review from lisbet-alvarez

Assignees
No one assigned
Labels
addons admin styles-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurenolivia @cameronperera @lisbet-alvarez